Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add archive_batch #180

Merged
merged 3 commits into from
Jan 12, 2024
Merged

feat: add archive_batch #180

merged 3 commits into from
Jan 12, 2024

Conversation

l-7-l
Copy link
Contributor

@l-7-l l-7-l commented Jan 11, 2024

#179 Note I haven't tested it yet because:

  1. I cannot connect to pgmq docker container(quay.io/tembo/pgmq-pg:latest) pgmq client error Failed to connect to postgres: error: DatabaseError(PoolTimedOut)

  2. Follow the instructions in CONTRIBUTING
    2.1 Running cargo pgrx init --pg15=which pg_config` will report error: unexpected argument 'not' found
    2.2 cargo pgrx install --release will report an error ```couldn't get cargo metadata```
    2.3 I cannot download the 0.11 version of pgrx. The following is the error:

error[E0412]: cannot find type `pid_t` in crate `libc`
   --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:21:18
    |
21 | Parent(libc::pid_t),
    | ^^^^^ not found in `libc`

error[E0425]: cannot find function `fork` in crate `libc`
    --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:112:30
     |
112 | let res = unsafe { libc::fork() };
     | ^^^^ not found in `libc`

error[E0412]: cannot find type `pid_t` in crate `libc`
    --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:128:33
     |
128 | pub fn setsid() -> Result<libc::pid_t, i32> {
     | ^^^^^ not found in `libc`

error[E0425]: cannot find function `setsid` in crate `libc`
    --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:129:30
     |
129 | let res = unsafe { libc::setsid() };
     | ^^^^^^ help: a function with a similar name exists: `getpid`
     |
    ::: C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\libc-0.2.149\src\windows\mod.rs:491:5
     |
491 | pub fn getpid() -> ::c_int;
     | -------------------------- similarly named function `getpid` defined here

error[E0412]: cannot find type `pid_t` in crate `libc`
    --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:140:34
     |
140 | pub fn getpgrp() -> Result<libc::pid_t, i32> {
     | ^^^^^ not found in `libc`

error[E0425]: cannot find function `getpgrp` in crate `libc`
    --> C:\Users\l-7-l\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fork-0.1.22\src\lib.rs:141:30
     |
141 | let res = unsafe { libc::getpgrp() };
     | ^^^^^^^ not found in `libc`

Some errors have detailed explanations: E0412, E0425.
For more information about an error, try `rustc --explain E0412`.

Copy link
Collaborator

@v0idpwn v0idpwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @l-7-l, looks great! I pushed a commit adding a test.

@v0idpwn
Copy link
Collaborator

v0idpwn commented Jan 12, 2024

With regards to your issue building the extension, what's the output of which pg_config?

@v0idpwn v0idpwn enabled auto-merge (squash) January 12, 2024 04:04
@v0idpwn v0idpwn merged commit 7283721 into tembo-io:main Jan 12, 2024
11 of 13 checks passed
@ChuckHend ChuckHend mentioned this pull request Jan 12, 2024
@ChuckHend
Copy link
Member

@l-7-l , we just released this https://crates.io/crates/pgmq

@l-7-l
Copy link
Contributor Author

l-7-l commented Jan 14, 2024

@l-7-l , we just released this https://crates.io/crates/pgmq

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants